Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config.py] Config.load do not deepcopy the default dict #219

Closed
iblislin opened this issue Jan 13, 2016 · 1 comment
Closed

[config.py] Config.load do not deepcopy the default dict #219

iblislin opened this issue Jan 13, 2016 · 1 comment
Assignees
@iblislin
Milestone
1.0.2

Comments

@iblislin
Copy link
Collaborator

Here is a potential bug:

When the Config inits, it pass the Config.DEFAULTS to self.load.
The self.load do not use deepcopy but reference.
iblislin added a commit that referenced this issue Jan 13, 2016
@iblislin
[#219] use deepcopy when Config.load copy param default
764ee46 
test case included
@iblislin iblislin mentioned this issue Jan 13, 2016
Closed
18 tasks
@iblislin iblislin self-assigned this Jan 13, 2016
@iblislin iblislin modified the milestone: 1.0.2 Jan 14, 2016
iblislin added a commit that referenced this issue Jan 15, 2016
@iblislin
[#219] use deepcopy when Config.load copy param default
ba6c0c2 
test case included

Merge pull request #220 from couchapp/issue-219
iblislin added a commit that referenced this issue Jan 15, 2016
@iblislin
[#219] use deepcopy when Config.load copy param default
0202c1b 
test case included
@iblislin
Copy link
Collaborator Author

Closed via ba6c0c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iblislin iblislin

Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
1 participant
@iblislin