Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBLDatabase not getting attachments from ancestry when processing attachments #843

Closed
pasin opened this issue Aug 5, 2015 · 0 comments
Closed

CBLDatabase not getting attachments from ancestry when processing attachments #843

pasin opened this issue Aug 5, 2015 · 0 comments
Assignees
@pasin
Labels
bug
Milestone
1.2

Comments

@pasin
Copy link
Contributor

pasin commented Aug 5, 2015

Originally reported by https://github.com/couchbase/couchbase-lite-java-core/issues/677.
@pasin pasin added the bug label Aug 5, 2015
@pasin pasin self-assigned this Aug 5, 2015
@pasin pasin added this to the 1.2 milestone Aug 5, 2015
pasin added a commit that referenced this issue Aug 5, 2015
@pasin
Fix process attachments when the parent rev is a _deleted rev
128ff11 
When the intermediate parent rev is _deleted rev, the status returned when getting the parentAttachments will be kCBLStatusOK instead of kCBLStatusNotFound. So it should go to the same logic as when the stastus is kCBLStatusNotFound to get the attachment from the attachment revpos instead.

#843
@pasin pasin mentioned this issue Aug 5, 2015
Merged
pasin added a commit that referenced this issue Aug 5, 2015
@pasin
Fix process attachments when the parent rev is a _deleted rev
aefde4a 
When the intermediate parent rev is _deleted rev, the status returned when getting the parentAttachments will be kCBLStatusOK instead of kCBLStatusNotFound. So it should go to the same logic as when the stastus is kCBLStatusNotFound to get the attachment from the attachment revpos instead.

#843
@pasin pasin closed this as completed Aug 5, 2015
@pasin pasin mentioned this issue Aug 5, 2015
Closed
@pasin pasin mentioned this issue Sep 2, 2015
Closed
pasin added a commit that referenced this issue Sep 2, 2015
@pasin
Fix process attachments when the parent rev is a _deleted rev
9e0cb4d 
When the intermediate parent rev is _deleted rev, the status returned when getting the parentAttachments will be kCBLStatusOK instead of kCBLStatusNotFound. So it should go to the same logic as when the stastus is kCBLStatusNotFound to get the attachment from the attachment revpos instead.

#843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasin pasin

Labels
bug
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@pasin