Fix #838 Implement readOnly to CBLSyncListener #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
changed the title
| CBLStatus status = self.onSyncAccessCheck(request, docID); | ||
| if (CBLStatusIsError(status)) { | ||
| NSString* message; | ||
| [request respondWithErrorCode: CBLStatusToHTTPStatus(status, &message) |
There was a problem hiding this comment.
This is a race condition: it's not guaranteed that CBLStatusToHTTPStatus will have been called before the message parameter is pushed on the stack. You'll need to break the function call out and put it above this line.
- Added OnSyncAccessCheckBlock property to CBLSyncConnection similarly to CBL_Router.OnAccessCheckBlock property. OnSyncAccessCheckBlock (if specified) will be called to check the access for each sync request coming to the CBLSyncConnection's handlers. The handlers will then return the corresponding error responses depending on the result of the OnSyncAccessCheckBlock call. - In read only mode, CBLSyncListener will block access to setCheckpoint, changes, and rev requests. #838
pasin
force-pushed
the
feature/issue_838_synclistener_readonly
branch
from
2e8f708
to
6fd7e8a
Compare
That makes sense. We can optimize this by adding the docID as a property of the request so that it's quicker to get it. (And then we have to make sure that it matches the docID parsed from the JSON, in case the peer tries to cheat...) |
snej
added a commit
that referenced
this pull request
Aug 15, 2015
…_readonly Fix #838 Implement readOnly to CBLSyncListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement readOnly mode in CBLSyncListener #838