Update dotnet maxsize usage for multiplexing io service #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Content is up for review at http://docs-build.sc.couchbase.com/server/2039. If any of the links return a 404, then the file is not in the ditamap. |
|
Build finished. |
MikeGoldsmith
force-pushed
the
net-mux-maxsize
branch
from
366e965
to
3bc6989
Compare
|
Content is up for review at http://docs-build.sc.couchbase.com/server/2039. If any of the links return a 404, then the file is not in the ditamap. |
|
Build finished. |
ingenthr
reviewed
Nov 28, 2017
| @@ -441,8 +441,9 @@ var bucket = cluster.OpenBucket("travel-sample");</codeblock></p> | |||
| <tbody> | |||
| <row> | |||
| <entry dir="ltr"><codeph>MaxSize</codeph></entry> | |||
| <entry dir="ltr">The maximum number of TCP connection to use<p><b>Note</b>: not used | |||
| with Multiplexing IO Service</p></entry> | |||
| <entry dir="ltr">The maximum number of TCP connection to use<p><b>Note</b>: Multiplexing | |||
There was a problem hiding this comment.
I'm a bit late, but shouldn't this be "connections" @RichardSmedley ?
There was a problem hiding this comment.
Yep, it should. I'll create a new PR.
There was a problem hiding this comment.
Yes (oops) - I see it's been corrected already in master; I've just changed it in 4.5 and 4.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docs say we do not use MaxSize for MultiplexingIOService, where we do use it for the pool size and create all connections during initialisation phase.