Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotnet maxsize usage for multiplexing io service #2039

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Update dotnet maxsize usage for multiplexing io service #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions content/sdk/dotnet/client-settings.dita
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,9 @@ var bucket = cluster.OpenBucket("travel-sample");</codeblock></p>
<tbody>
<row>
<entry dir="ltr"><codeph>MaxSize</codeph></entry>
<entry dir="ltr">The maximum number of TCP connection to use<p><b>Note</b>: not used
with Multiplexing IO Service</p></entry>
<entry dir="ltr">The maximum number of TCP connection to use<p><b>Note</b>: Multiplexing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late, but shouldn't this be "connections" @RichardSmedley ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it should. I'll create a new PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes (oops) - I see it's been corrected already in master; I've just changed it in 4.5 and 4.6.

IO Service creates the number of MaxSize connections during the initialize phase.
</p></entry>
<entry dir="ltr">2</entry>
</row>
<row>
Expand Down