Skip to content

Commit

Permalink
MB-31938 ManifestUID is required for all DCP request
Browse files Browse the repository at this point in the history
Once collections have been enabled, all DCP stream requests
must provide manifestUID if seq num is non-zero

Change-Id: I136be5bb50a3dd6613ec42efd94a43b4323b1b87
  • Loading branch information
deepkaran authored and Deepkaran Salooja committed May 14, 2020
1 parent 30d0de2 commit 73d729b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions secondary/dcp/transport/client/dcp_feed.go
Original file line number Diff line number Diff line change
Expand Up @@ -849,15 +849,15 @@ func (feed *DcpFeed) doDcpRequestStream(
requestValue.ManifestUID = manifestUID
requestValue.ScopeID = scopeId
requestValue.CollectionIDs = collectionIds

body, _ := json.Marshal(requestValue)
rq.Body = body
} else {
// ScopeId being empty and no collectionId specified will
// open the stream for entire bucket. For such a
// scenario, it is not required to specify anything
// in request body
// scenario, only manifestUID is required to be specified
// in request body.
requestValue.ManifestUID = manifestUID
}
body, _ := json.Marshal(requestValue)
rq.Body = body
}

// Here, timeout can occur due to slow memcached. The error handling
Expand Down

0 comments on commit 73d729b

Please sign in to comment.