Add requireAdmin() to Sync Function (Fixes #3276) #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFlath
commented
Feb 6, 2018
| runner, err := NewSyncRunner(funcSource) | ||
| assert.Equals(t, err, nil) | ||
| var result interface{} | ||
| result, _ = runner.Call(parse(`{}`), parse(`{}`), parse(`{}`)) |
There was a problem hiding this comment.
AFAIK, this is equivalent to how a request from the Admin port will hit the Sync Function, but would appreciate a double-check on this.
JFlath
commented
Feb 6, 2018
| assertNotRejected(t, result) | ||
| result, _ = runner.Call(parse(`{}`), parse(`{}`), parse(`{"name": ""}`)) | ||
| assertRejected(t, result, base.HTTPErrorf(403, "admin required")) | ||
| result, _ = runner.Call(parse(`{}`), parse(`{}`), parse(`{"name": "GUEST"}`)) |
There was a problem hiding this comment.
As above, AFAIK this should represent a request as the GUEST user, but a double-check of my logic here would be good.
JFlath
force-pushed
the
feature/issue_3276
branch
from
74d4fd8
to
d21a473
Compare
JFlath
force-pushed
the
feature/issue_3276
branch
2 times, most recently
from
31d869b
to
23e772a
Compare
bbrks
reviewed
Feb 6, 2018
|
@JFlath This looks good to me, but it looks like it pulled in an unnecessary manifest change somewhere along the way. Do you mind rebasing to get rid of that, then ping me and I can merge? |
|
Hey, when I tried the first time, I think I pulled in 200-odd commits, it's an improvement 😂! Will sort it out when I get a sec, thanks! |
JFlath
force-pushed
the
feature/issue_3276
branch
from
23e772a
to
df19aaf
Compare
JFlath
force-pushed
the
feature/issue_3276
branch
from
df19aaf
to
7a8f1dd
Compare
adamcfraser
approved these changes
Apr 12, 2018
|
/me adds Golang to LinkedIn skills |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3276 This adds a new callback to the Sync Function:
This allows rejecting mutations that don't come via the Admin port.