CBG-1242 - Strongly typed EventHandlerConfig #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
adamcfraser
approved these changes
Jan 4, 2021
adamcfraser
pushed a commit
that referenced
this pull request
Jan 13, 2021
…ption (#4909) * [2.8.1 Backport] Fix empty webhook payload logging due to buffer-reuse (#4891) * [2.8.1 Backport] Use standard config schema validation for event handler config validation (#4898) * [2.8.1 Backport] Add winning_rev_only option to DocumentChanged event handler config (#4901) * Add String method to EventType for better logging * Add winning_rev_changed event handler * Rework winning rev only option for DocumentChanged event to use generic options supplied to all event handlers/webhooks. * Add missing params in event/webhook functions * Remove old event type * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses strongly typed
EventHandlerConfigfor existing config validation handling