-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBG-1244 - Add winning_rev_only option to DocumentChanged event handler config #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
requested changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General approach looks good, a couple of questions.
…ic options supplied to all event handlers/webhooks.
@adamcfraser addressed comments but rebased to pick up fix on |
adamcfraser
approved these changes
Jan 8, 2021
bbrks
added a commit
that referenced
this pull request
Jan 12, 2021
… handler config (#4901) * Add String method to EventType for better logging * Add winning_rev_changed event handler * Rework winning rev only option for DocumentChanged event to use generic options supplied to all event handlers/webhooks. * Add missing params in event/webhook functions * Remove old event type * Address PR comments
bbrks
added a commit
that referenced
this pull request
Jan 13, 2021
… handler config (#4901) * Add String method to EventType for better logging * Add winning_rev_changed event handler * Rework winning rev only option for DocumentChanged event to use generic options supplied to all event handlers/webhooks. * Add missing params in event/webhook functions * Remove old event type * Address PR comments
adamcfraser
pushed a commit
that referenced
this pull request
Jan 13, 2021
…ption (#4909) * [2.8.1 Backport] Fix empty webhook payload logging due to buffer-reuse (#4891) * [2.8.1 Backport] Use standard config schema validation for event handler config validation (#4898) * [2.8.1 Backport] Add winning_rev_only option to DocumentChanged event handler config (#4901) * Add String method to EventType for better logging * Add winning_rev_changed event handler * Rework winning rev only option for DocumentChanged event to use generic options supplied to all event handlers/webhooks. * Add missing params in event/webhook functions * Remove old event type * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document_changed.winning_rev_only=true/false
is the only allowed option.