Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to React Testing Library #311

Open
couds opened this issue Mar 28, 2021 · 2 comments · May be fixed by #426
Open

Migrate tests to React Testing Library #311

couds opened this issue Mar 28, 2021 · 2 comments · May be fixed by #426
Assignees
@couds
Labels
enhancement
Milestone
v4

Comments

@couds
Copy link
Owner

couds commented Mar 28, 2021

After some research I think it will be better to migrate the tests to react testing library and stop using snapshot for the tests, instead check that the bulma classes are present

I will work on this after finishing the docs (I'm finally workling on them).
@couds couds self-assigned this Mar 28, 2021
@couds couds added this to the v4 milestone Mar 28, 2021
@kennethnym
Copy link
Collaborator

I'll help with the docs.

@kennethnym
Copy link
Collaborator

@couds I created a branch migrate-testing for this issue. I'll start working on migrating some of the tests when i am free.

@couds couds linked a pull request Apr 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@couds couds

Labels
enhancement
Projects
None yet
Milestone
v4
Development

Successfully merging a pull request may close this issue.

Next Major Version of library couds/react-bulma-components
2 participants
@couds @kennethnym