-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Countly doesn't correctly remove consent for custom groups. #337
Comments
and cleanup code see Countly/countly-sdk-web#337
workaround until this is fixed: function checkConsent (consent: string) {
const featuresArray = this.groupedFeatures[consent]
if (featuresArray == null) {
return countlySdkWeb.check_consent(consent)
}
return featuresArray.every((feature) => countlySdkWeb.check_consent(feature))
} |
Hi SgtPooki thank you for reaching out. Consent grouping is a convenience method for adding or removing consent. It is not intended for using with check_consent function, which is implemented to check only a specific core consent, not a consent group. So currently that function is not tracking the state of consent groups and we do not want it to do that also in near feature. But as you have mentioned it, it would be better for us to give the developer a warning, stating that they should not be using this function with a consent group name. We will consider the possibility of this option in future releases. Thank you. |
@turtledreams Thanks for the extremely quick response. At the minimum, I would suggest a docs update, but it's good to know this is expected. |
See https://codepen.io/SgtPooki/pen/xxJKqBP?editors=1011
console log output is:
The text was updated successfully, but these errors were encountered: