Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizing country names in helper #27

Closed
dgilperez opened this issue Aug 2, 2013 · 4 comments
Closed

Localizing country names in helper #27

dgilperez opened this issue Aug 2, 2013 · 4 comments

Comments

@dgilperez
Copy link
Contributor

Hi!

I think this is a common need for many people and a major lack of the gem, which is great whatsoever.

I hacked the gem to get this functionality in the past: https://github.com/dgilperez/country_select/commits/master but it seems hacky and it's outdated.

I also saw @chrkau try another hack recently: chrkau@c56d351#commitcomment-3776245

My question: what would you choose as the best approach for this? I can get a couple of hours next week to work on it.

Regards!

dgilperez referenced this issue in chrkau/country_select Aug 2, 2013
@caio-ribeiro-pereira
Copy link

Hi,

How can I get this translatable version using gem "country_select" into my Gemfile? How use it into locales/lang.yml?

thanks!

@chrkau
Copy link

chrkau commented Aug 14, 2013

I said it before and will say it again: My code is nothing but an ugly hack. So I would strongly suggest not using it.

What we actually need is a clean implementation.

@stefanpenner
Copy link
Collaborator

@dgilperez + @chrkau do either of you have time to throw down a PR that does this nicely?

@stefanpenner
Copy link
Collaborator

closing in-favor of #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants