My contribution #32
Merged
My contribution #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid possible conflict by making the build config private to avoid it being defined in a user config file - Transform RunBefore and RunAfter into private array to allow cumulation of commands as it is done with build configs.
We wanted to execute scripts in reverse declared order but this code execute scripts in reverse string order (which is completely different)
Moving default initialization prior to evaluate the arguments breaks the argument parser (i.e. The default config is evaluated without considering the supplied arguments). This was also breaking when no argument was supplied The loop over a map was useless Add support for quoted arguments in alias
julienduchesne
approved these changes
Oct 29, 2018
Pull Request Test Coverage Report for Build 619
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.