Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the arg="value" format in alias definitions #58

Merged
merged 1 commit into from
May 1, 2019
Merged

Allow the arg="value" format in alias definitions #58

merged 1 commit into from
May 1, 2019

Conversation

julienduchesne
Copy link
Contributor

Putting --da="-e NODE_PATH=/generator-tgf/node_modules" in an alias configuration would parse to "-e NODE_PATH=/generator-tgf/node_modules (bad quote at the beginning)

@julienduchesne julienduchesne merged commit aebb01a into master May 1, 2019
@julienduchesne julienduchesne deleted the fix-alias-equal-arguments branch May 1, 2019 11:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 769

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.535%
Totals Coverage Status
Change from base Build 767: 0.0%
Covered Lines: 165
Relevant Lines: 941
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jocgir jocgir jocgir approved these changes

@dblanchette dblanchette Awaiting requested review from dblanchette

@AbdulRahmanAlHamali AbdulRahmanAlHamali Awaiting requested review from AbdulRahmanAlHamali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienduchesne @coveralls @jocgir