Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getIdpBinding - handle no bindings specified #29

Open
claylehman opened this issue Mar 26, 2019 · 0 comments
Open

getIdpBinding - handle no bindings specified #29

claylehman opened this issue Mar 26, 2019 · 0 comments

Comments

@claylehman
Copy link
Contributor

I am trying to hookup SAML with PingFederate.

The metadata.xml file generated by their system does NOT include any md:SingleSignOnService... data.

It would be nice for my users if they could just export the metadata.xml and use it as is in my system instead of having to manually add an entry for md:SingleSignOnService

I would like to build up a PR to make getIdpBinding() to return NULL if there were no md:SingleSignOnService at all, vs there were some, but none matched. Then downstream, I will make the places using the results of it handle null by defaulting to the value from assertionConsumerServiceUrl - sort of like the opposite of what you do if its Okta

claylehman added a commit to claylehman/saml-client that referenced this issue Mar 26, 2019
malaporte pushed a commit that referenced this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant