Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all libraries and required nodejs version #139

Closed
wants to merge 15 commits into from
Closed

Upgrade all libraries and required nodejs version #139

wants to merge 15 commits into from

Conversation

robsonpeixoto
Copy link

@robsonpeixoto robsonpeixoto commented Dec 24, 2022

This is a big PR, my bad 馃槥 , that:

  • remove the node_modules directory
  • upgrade all dependencies (16 vulnerabilities (6 moderate, 4 high, 6 critical))
  • upgrade to node 16
  • use vercel/ncc to package the .js file
  • remove not used configs from tsconfig.json
  • remove not used dependency

This github-action still have some problems:

  • using deprecated lib: https://www.npmjs.com/package/request
  • code is not formatted
  • coveralls dep has a lot of critical security problems: 29 vulnerabilities (1 low, 8 moderate, 14 high, 6 critical)

Everything was copied from https://github.com/actions/typescript-action

@jrfnl
Copy link

jrfnl commented Dec 24, 2022

Duplicate of #137 ?

@franky47
Copy link

Might as well use Node 18 for actions, as it's now the current LTS.

@robsonpeixoto
Copy link
Author

Only node12 and node16 are supported. Reference: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing

@robsonpeixoto
Copy link
Author

robsonpeixoto commented Dec 24, 2022

@jrfnl is not duplicate of #137, because this PR is a big refactor on the build process.
I updated the PR description to make clear what I did.

dogracer added a commit to Daring-Crypto-Ventures/hodl-totals that referenced this pull request Jan 3, 2023
this got submitted to a chore/upgrade branch last week, so will try @master instead of the @1.1.3 or @v1.1.2 options
coverallsapp/github-action#139
.gitignore Show resolved Hide resolved
@paescuj

This comment was marked as resolved.

@robsonpeixoto
Copy link
Author

Did you forget to commit the package.json & package-lock.json files?
@paescuj, read the commits below:

src/run.ts Outdated Show resolved Hide resolved
@paescuj
Copy link

paescuj commented Jan 3, 2023

Did you forget to commit the package.json & package-lock.json files?
@paescuj, read the commits below:

Ah, great! Sorry, it didn't show up in the diff because it's limited to 3.000 files :-)

@robsonpeixoto
Copy link
Author

Sorry! Delete the node_modules created a huge diff.

@paescuj
Copy link

paescuj commented Jan 3, 2023

Sorry! Delete the node_modules created a huge diff.

Definitely not your fault 馃槂

@fluxsauce
Copy link

This is amazing, thank you for working on this @robsonpeixoto !

@PaulRBerg
Copy link

Any ETA on when this PR will be reviewed and merged by the @coveralls team?

@robsonpeixoto
Copy link
Author

ping @nickmerwin @anjin

@CoreyGahafer
Copy link

@nickmerwin or @anjin can this be merged in?

@nopeless
Copy link

Hoping this will be merged soon so I don't have to see warnings :)

@szepeviktor
Copy link

@afinetooth Maybe we need someone to maintain this repo once a month. What do you think?

@robsonpeixoto robsonpeixoto closed this by deleting the head repository Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants