Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The set-output command is deprecated and will be disabled soon. #135

Closed
Apollon77 opened this issue Oct 18, 2022 · 4 comments
Closed

The set-output command is deprecated and will be disabled soon. #135

Apollon77 opened this issue Oct 18, 2022 · 4 comments

Comments

@Apollon77
Copy link

We get some warnings on GitHub when using the action (master version):

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@gabririgo
Copy link

gabririgo commented Oct 19, 2022 •
edited
Loading

also this warning is produced:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: coverallsapp/github-action

@jakirkham
Copy link

Was just setting this up using the latest version today and saw this warning.

@jakirkham jakirkham mentioned this issue Oct 20, 2022
Merged
@RobinTail RobinTail mentioned this issue Oct 21, 2022
Merged
@JohnTitor JohnTitor mentioned this issue Oct 25, 2022
Closed
@ooxi ooxi mentioned this issue Nov 4, 2022
Open
@hardbyte hardbyte mentioned this issue Nov 14, 2022
Merged
@tomhughes tomhughes mentioned this issue Nov 17, 2022
Closed
@pmienk pmienk mentioned this issue Nov 17, 2022
Closed
@nmanu1 nmanu1 mentioned this issue Nov 17, 2022
Merged
nmanu1 added a commit to yext/slapshot-reusable-workflows that referenced this issue Nov 18, 2022
@nmanu1
Update set-output calls (#25)
6d6fda1 
Update the calls to `set-output` since it is deprecated and will be removed. Followed the suggestion [here](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) and, for our `get-coverage-percent` action, upgraded to v1.10.0 of `@actions/core` which updates how it sets output variables under the hood. Also, updated the `Endbug/add-and-commit` action from v7 to v9, which uses the updated way to set output variables.

Note: There is still one `set-output` warning left, which comes from `coverallsapp/github-action` in the `coverage` workflow. There is already an [issue](coverallsapp/github-action#135) made on that repo and it seems to be waiting on the merging of [this PR](coverallsapp/github-action#136). Since we are pointing to their `master` branch, once the PR is merged, we will get the fix without any action needed on our part.

J=SLAP-2427
TEST=manual

Tested with a forked version of Core and ran tests on `search-ui-react` for the Percy and WCAG workflows. Saw that there were no more warnings for `set-output` (except for the one mentioned above).
@eudoxa eudoxa mentioned this issue Nov 24, 2022
Merged
6 tasks
@robsonpeixoto
Copy link

The PR #139 address it

@rng-dynamics rng-dynamics mentioned this issue Jan 3, 2023
Closed
@rossbar rossbar mentioned this issue Feb 23, 2023
Merged
@mrexox
Copy link
Contributor

mrexox commented Feb 27, 2023

Hey! In a new @v1.2.1 and @v1 (and also @master) versions this is fixed. Please, upgrade!

@mrexox mrexox closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade @actions/core to 1.10.0 JohnTitor/github-action
5 participants
@robsonpeixoto @jakirkham @Apollon77 @gabririgo @mrexox