Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage breaks strong-name signature, causing test failure on .NET Framework #471

Closed
AArnott opened this issue Jun 16, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@AArnott
Copy link
Contributor

AArnott commented Jun 16, 2019

When my repo strong-name signs its assemblies and I execute a test run with code coverage on .NET Framework, dotnet test ultimately fails because when it shadow-copies the assembly, the strong-name signature is checked and found to be invalid.
I wonder if this is because the code coverage changes the IL in the assembly, thus invalidating its signature.

Is this a known issue? If not, I can provide repro steps if necessary.

@AArnott AArnott changed the title Code coverage breaks strong-name signature, causing test failure Code coverage breaks strong-name signature, causing test failure on .NET Framework Jun 16, 2019
@MarcoRossignoli
Copy link
Collaborator

Is a dup of #347?

@MarcoRossignoli MarcoRossignoli added the needs more info More details are needed label Jun 17, 2019
@AArnott
Copy link
Contributor Author

AArnott commented Jun 17, 2019

Yes. Thanks.

@AArnott AArnott closed this as completed Jun 17, 2019
@MarcoRossignoli MarcoRossignoli added duplicate This issue or pull request already exists and removed needs more info More details are needed labels Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants