Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink hits report strategy #808

Closed
MarcoRossignoli opened this issue Apr 10, 2020 · 1 comment
Closed

Rethink hits report strategy #808

MarcoRossignoli opened this issue Apr 10, 2020 · 1 comment
Labels
discussion Generic discussion on something feature-request New feature request

Comments

@MarcoRossignoli
Copy link
Collaborator

After a prolific talk with @jakubch1 we could try to change hits report strategy to solve mainly two issue:

  1. On collectors side remove embedded coverlet code for in-process load inside vstest repo

Possible solution: we could change tracker to report hits in a shared memory open by out-of-proc data collector.

  1. Be resilient in case of "fast kill" issue on msbuild driver https://github.com/tonerdo/coverlet/blob/master/Documentation/KnownIssues.md#1-vstest-stops-process-execution-earlydotnet-test

Possible solution: report hits directly to persisted memory-mapped file https://docs.microsoft.com/en-us/dotnet/standard/io/memory-mapped-files

In past an attempt to use shared memory/memory mapped file(on flush not for every hit registration, so we need also to take care of performace against int array) with no luck due to special needs of System.Private.CoreLib #276 (comment), if we take this path maybe we need to avoid such dependency and wrap native api cross plat.

@MarcoRossignoli
Copy link
Collaborator Author

Moved to discussion panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Generic discussion on something feature-request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant