Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to be done on dlt internal buffer allocation logic #37

Closed
anoojgopi opened this issue Jan 24, 2018 · 1 comment
Closed

Improvement to be done on dlt internal buffer allocation logic #37

anoojgopi opened this issue Jan 24, 2018 · 1 comment
Assignees

Comments

@anoojgopi
Copy link

anoojgopi commented Jan 24, 2018

Currently we the allocation/de-allocation logic does unneccessary memory copy causing CPU load and on top we need double the heap size than it actually requires in usual cases.

Let's say we configure the dlt buffer size as 20 MB, we need approx 40 MB during the allocation of the final step size.

Same logic is used in dltlib, this all applications are also affected due to this inefficient logic.

We need to improve it.

@anoojgopi anoojgopi changed the title Imrovement to be done on dlt internal buffer allocation logic Improvement to be done on dlt internal buffer allocation logic Jan 24, 2018
@ssugiura ssugiura self-assigned this Jul 26, 2019
@ssugiura
Copy link
Collaborator

@anoojgopi Sorry that we haven't replied to your request for long time. The allocation/deallocation should only happen in rare cases; the daemon is not alive yet, some issues in socket/fifo buffers, too much logging happening, etc. If it is happening often for a specific dlt-user, the application should be configured with the env variables in a way that it does not happen anymore:

DLT_USER_BUFFER_MAX
DLT_USER_BUFFER_MIN
DLT_USER_BUFFER_STEP

If you have any further request, please reopen this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants