Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Less 1.3.3 (Including new stubs) #51

Merged
merged 1 commit into from
Mar 4, 2013

Conversation

jscheel
Copy link
Contributor

@jscheel jscheel commented Jan 6, 2013

This pull request updates the submodule to less 1.3.3 and updates loader.rb so that it bridges the new http import concatenation that 1.3.3 has to ruby's http module. Not sure if it's great or not, since I don't really write much ruby, but it seems to be working. I have not updated any of the specs, sorry.

@aziz
Copy link

aziz commented Jan 11, 2013

👍

1 similar comment
@WaYdotNET
Copy link

👍

@cvrebert cvrebert mentioned this pull request Feb 12, 2013
@emorikawa
Copy link

+1

@WaYdotNET
Copy link

the project is dead?

@jscheel
Copy link
Contributor Author

jscheel commented Feb 21, 2013

I wouldn't think so. @cowboyd has a lot of other projects to maintain, so I'm guessing he's busy with those. At least I hope that's the case.

@metaskills
Copy link
Collaborator

FWIW, I have worked around this in less-rails-bootstrap and upgraded it to v2.3.0 of twitter/bootstrap. I did this by reverting these few lines in mixins.less to the old syntax.

https://gist.github.com/metaskills/5024393

So this takes the pressure off of less.rb for a little while. I would suggest that if anyone wants this to get merged faster to take up some free time and write a few simple tests that makes sure the new syntax works. Should be easy and only take a few minutes, just pick a few 1.3.3 features and piggy back on the tests that @cowboyd has already done.

@cowboyd
Copy link
Owner

cowboyd commented Feb 27, 2013

I'm getting the following errors when bringing this change in:

https://gist.github.com/cowboyd/5048348

Are you seeing these?

@jscheel
Copy link
Contributor Author

jscheel commented Feb 27, 2013

No worries for the delay. I haven't, updated the tests yet, and there's
definitely a possibility that some stuff is actually broken, instead of the
tests being out of date. On my phone right now, but I'll take a look in a
bit.

On Wednesday, February 27, 2013, Charles Lowell wrote:

I'm getting the following errors when bringing this change in:

https://gist.github.com/cowboyd/5048348


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-14176817
.

@avsej
Copy link
Contributor

avsej commented Feb 28, 2013

I've made pull-request to populr#1 because I guess after merging its branch will be updated and the change will automatically appear in this pull-request

@ka8725
Copy link

ka8725 commented Mar 3, 2013

👍

1 similar comment
@messick
Copy link

messick commented Mar 4, 2013

👍

@cowboyd
Copy link
Owner

cowboyd commented Mar 4, 2013

@jscheel so how about bringing in @avsej's changes into this PR? Looks like he's done the legwork.

@avsej
Copy link
Contributor

avsej commented Mar 4, 2013

awesome :)

@nicovalencia
Copy link

👍

@jscheel
Copy link
Contributor Author

jscheel commented Mar 4, 2013

@avsej thanks for the work on that! Sorry it took so long, I've been knee-deep in a long release for the past several days.

@avsej
Copy link
Contributor

avsej commented Mar 4, 2013

No problem, you've done most of the work there

@cowboyd cowboyd merged commit 2e451e3 into cowboyd:master Mar 4, 2013
@cowboyd cowboyd mentioned this pull request Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants