-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Less 1.3.3 (Including new stubs) #51
Conversation
👍 |
1 similar comment
👍 |
+1 |
the project is dead? |
I wouldn't think so. @cowboyd has a lot of other projects to maintain, so I'm guessing he's busy with those. At least I hope that's the case. |
FWIW, I have worked around this in less-rails-bootstrap and upgraded it to v2.3.0 of twitter/bootstrap. I did this by reverting these few lines in mixins.less to the old syntax. https://gist.github.com/metaskills/5024393 So this takes the pressure off of less.rb for a little while. I would suggest that if anyone wants this to get merged faster to take up some free time and write a few simple tests that makes sure the new syntax works. Should be easy and only take a few minutes, just pick a few 1.3.3 features and piggy back on the tests that @cowboyd has already done. |
I'm getting the following errors when bringing this change in: https://gist.github.com/cowboyd/5048348 Are you seeing these? |
No worries for the delay. I haven't, updated the tests yet, and there's On Wednesday, February 27, 2013, Charles Lowell wrote:
|
I've made pull-request to populr#1 because I guess after merging its branch will be updated and the change will automatically appear in this pull-request |
👍 |
1 similar comment
👍 |
Fix tests for less 1.3.3
awesome :) |
👍 |
@avsej thanks for the work on that! Sorry it took so long, I've been knee-deep in a long release for the past several days. |
No problem, you've done most of the work there |
This pull request updates the submodule to less 1.3.3 and updates loader.rb so that it bridges the new http import concatenation that 1.3.3 has to ruby's http module. Not sure if it's great or not, since I don't really write much ruby, but it seems to be working. I have not updated any of the specs, sorry.