Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile browser chrome does not disappear when we scroll #169

Closed
ptbrowne opened this issue Sep 6, 2017 · 8 comments
Closed

Mobile browser chrome does not disappear when we scroll #169

ptbrowne opened this issue Sep 6, 2017 · 8 comments

Comments

@ptbrowne
Copy link
Contributor

ptbrowne commented Sep 6, 2017

The UI of the browser must disappear when we scroll.

@enguerran
Copy link
Contributor

You could use peek to record a gif instead of a static screenshot ;)

@ptbrowne
Copy link
Contributor Author

ptbrowne commented Sep 6, 2017

Thanks enguerran, I did not know peek, I was using Quicktime screen recorder and a bash script using ffmpeg to do my own gifs. Peek looks easier to use 👍

Here though, I think I do not have to put a screencast, it is fairly simple : when you scroll in the drive app on mobile, the browser's chrome does not disappear. It should.

@GoOz I think it is related to #161

@GoOz
Copy link
Contributor

GoOz commented Sep 6, 2017

Actually it shoudn't. Same on Safari iOS.
What you scroll when you scroll is the inside of the content wrapper which has a height relative to the viewport's height. And because it's the content wrapper you scroll and not the body both Chrome & Safari don't trigger their "minimized UI" or whatever name they put on it.

So far, I can't fix it due to some library we use to display long list etc. That's just complicated. That's part of the reasons we tried to reconsider the existing layout.

TL;DR: We know about it, we'll see what we'll do with it later because there's no easy fix.

@ptbrowne
Copy link
Contributor Author

ptbrowne commented Sep 6, 2017

When I say "it should", I mean the expected behavior for the user. I am not talking about the technical aspects of this problem.

How can we follow the progress on this ?

@GoOz
Copy link
Contributor

GoOz commented Sep 6, 2017

There's some debug & exploration to be done first, perhaps this sprint but most likely next sprint. I'll keep you posted.

@y-lohse
Copy link
Contributor

y-lohse commented Sep 29, 2017

@GoOz what is the status of this? Were you abble to find a way to "fix" this?

@GoOz
Copy link
Contributor

GoOz commented Sep 29, 2017

@y-lohse It's WIP :) The new layout is on Cozy-Bank only for now. When we can get rid of React-Virtualized on Drive, it's planned to extend the fix from bank to UI. But I can't add it right now without breaking things. Well, I could but with tweaks here and there that are not worth it as the removal of virtualized content is planned.

@GoOz
Copy link
Contributor

GoOz commented Dec 15, 2017

New layout for mobile is merged. 🎉

@GoOz GoOz closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants