-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghi: move ROCm image to our hub.docker.com org #430
Comments
Let me fix this |
By the way, generally it's fine to use Ubuntu 20.04, but the downside is that you get a very recent libc, so if you decide to run this docker image on Daint with the |
Well, I don't mind upgrading them to 20.04. But I just discovered another problem: Docker restricted the options in the Free edition of Docker hub, meaning that I can't hand out granular permissions anymore (permissions on existing repos still work). So I had to make the
If it doesn't please let me know, then we have to try something else. Also, I can add you to the Docker Hub organization if needed. We might even start looking for something else anyway since Docker also started to restrict the pull frequency (which may trip the CI) and I don't like handing out elevated permissions to a bot user. |
You can also push to github, right? |
What's the lowest Ubuntu version that we can use on Daint, 18.04? I also think we should avoid to use new libc... |
yes, but there were issues at the beginning with the GH CI integration, if that is fixed we can use the GitHub Packages, but it seems they moved it to the org and is only accessible directly since it's probably deactivated on the CP2K org. |
and
I've always used ubuntu 18.04 without any problem, but apparently ubuntu:16.04 is best :/ |
Forget my previous comment, I see HIP is using 18 (https://github.com/cp2k/dbcsr/tree/develop/tools/docker) |
I just changed that to ubuntu 20.04 in #432 because the other ubuntu image uses that too and it would be fewer lines to install compilers and libs 😅 Let me see how much work it is to move everything to ubuntu 18.04. |
I'd stick to ubuntu 20.04 for now. There's multiple issues with ubuntu 18.04:
|
Well, 20.04 is fine, of course... |
The ROCm build tests currently uses an image from @shoshijak, we should migrate that to our Docker hub and rebuild/update the image periodically like we do with the others.
Note: the Docker Hub Repo is already there and GHI should have push access, so the only things remaining are:
.github/workflows/docker-build-env.yml
for the ROCm Docker intools/docker/Dockerfile.build-env-rocm
.github/workflows/testing-linux.yml
The text was updated successfully, but these errors were encountered: