fix: Update static_files.py #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if the best way to do it, but this resolved the issue with locating the static files.
cpacker
approved these changes
May 5, 2024
Thanks. I don't know what to do (if anything) about the checks that failed. |
I'm not sure why the remaining tests aren't passing - seems to be a bug with the workflows running on forks vs the main branch (might have regressed in the last few PRs). Merging for now (tests should pass on main), will look into it! |
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: cpacker <packercharles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the best way to do it, but this resolved the issue with locating the static files to resolve.
Please describe the purpose of this pull request.
Fix a bug (see below)
How to test
Install memgpt via pip and run
memgpt serverfrom a different directory than where the memgpt package is installed.Have you tested this PR?
Yes. The path to the static path comes back correct and dev portal works.
Related issues or PRs
[#1339]
Is your PR over 500 lines of code?
Nope.
Additional context
None that I can think of.