Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix typing errors (pyright) #855

Merged
merged 14 commits into from
Jan 24, 2024
Merged

refactor: fix typing errors (pyright) #855

merged 14 commits into from
Jan 24, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Jan 19, 2024

Please describe the purpose of this pull request.

  • Add pyright to github actions
  • Do a full pass over the codebase to correct pyright errors
  • Disable continue on error on github actions once pyright is passing

How to test

  • Unit tests pass
  • pyright passes

@cpacker cpacker merged commit 7ec216d into main Jan 24, 2024
4 checks passed
@cpacker
Copy link
Collaborator Author

cpacker commented Jan 24, 2024

Tagging #916

@cpacker cpacker deleted the pyright branch January 24, 2024 04:34
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant