Record whether perl was built with taint support enabled or not #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that perl can actually pass its own tests with taint support disabled, CPAN::Reporter needs to pay attention to this so that we can test against the same version of perl with and without this feature. Without this, if you have already tested a dist against a normal perl 5.37.11 (for example) and then try to test against 5.37.11 with no taint support, you'll not send test reports reliably using the second build. There are no doubt other obscure options that should be dealt with similarly, and can be added later.
|
@garu DrHyde has poked me asking you to please merge this at PTS 2023 :) |
|
Looks great! Merged <3 |
|
...and CPAN-Reporter 1.2019 is on its way to CPAN now 🥳 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that perl can actually pass its own tests with taint support disabled, CPAN::Reporter needs to pay attention to this so that we can test against the same version of perl with and without this feature. Without this, if you have already tested a dist against a normal perl 5.37.11 (for example) and then try to test against 5.37.11 with no taint support, you'll not send test reports reliably using the second build.
There are no doubt other obscure options that should be dealt with similarly, and can be added later.