Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch utils for non recursive links #7

Merged
merged 1 commit into from May 22, 2015

Conversation

@nhumrich
Copy link
Contributor

nhumrich commented May 5, 2015

Currently RecurisionError is thrown even for sideways links. This change checks for a recursive link versus a duplicate link and handles them differently.

Currently RecursionError is thrown even on sideways symlinks. This fix checks for recursive links versus sideways links.
@nhumrich nhumrich force-pushed the nhumrich:patch-1 branch from bc0ae6e to 081cc4b May 5, 2015
@cpburnz

This comment has been minimized.

Copy link
Owner

cpburnz commented May 21, 2015

@nhumrich Can you provide an example of a "sideways" link? It's not really clear to me what one is.

@nhumrich

This comment has been minimized.

Copy link
Contributor Author

nhumrich commented May 22, 2015

Ya sorry, I should be more correct in the words I use. Basically, just any link thats not recursive. But a simple example is:
./foo/bar -> ./foo/baz
Since bar points to baz and baz doesnt contain bar, there is no recursion and everything works ok.

cpburnz added a commit that referenced this pull request May 22, 2015
Patch utils for non recursive links
@cpburnz cpburnz merged commit 23eb432 into cpburnz:master May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.