Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2637 R3 Member visit #1303

Closed
wg21bot opened this issue Sep 22, 2022 · 11 comments · Fixed by cplusplus/draft#6350
Closed

P2637 R3 Member visit #1303

wg21bot opened this issue Sep 22, 2022 · 11 comments · Fixed by cplusplus/draft#6350
Labels
C++26 Targeted at C++26 IS Ship vehicle: IS plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - medium paper size estimate
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Sep 22, 2022

P2637R0 Member visit and apply (Barry Revzin)

@wg21bot wg21bot added the LEWG Library Evolution label Sep 22, 2022
@wg21bot wg21bot added this to the 2022-telecon milestone Sep 22, 2022
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS C++26 Targeted at C++26 size - medium paper size estimate ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Sep 22, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 17, 2022

P2637R1 Member visit (Barry Revzin)

@brycelelbach
Copy link

brycelelbach commented Nov 2, 2022

2022-10-04 Library Evolution Telecon

P2637R0: Member visit and apply

2022-10-04 Library Evolution Telecon Minutes

Chair: Nevin Liber

Champion: Tim Song

Minute Taker: Inbal Levi

POLL: Remove std::apply from P2637.

SF F N A SA
2 6 6 1 0

Attendance: 18

# of Authors: 0

Author Position:

Outcome: Weak consensus in favor

WA: Trust the experience of the author for the usability

POLL: Should we hold up this paper until we have investigated a variadic visit?

SF F N A SA
0 1 2 4 4

Attendance: 17

# of Authors: 0

Author Position:

Outcome: Consensus against

POLL: Should the next version of this paper remove the constraint (from 1.4) which rejects those cases where a type might inherit privately from variant.

SF F N A SA
3 3 4 1 0

Attendance: 16

# of Authors: 0

Author Position:

Outcome: Consensus in favor

WA: Don't see the need to support this

POLL: We should promise more committee time to pursuing P2637 Member Visit, knowing that our time is scarce and this will leave less time for other work.

SF F N A SA
7 4 2 1 0

Attendance: 17

# of Authors: 0

Author Position:

Outcome: Consensus in favor

WA: I think we need language changes before we pursue these types of ergonomic things.

Summary

TODO: @nliber

Next Steps

TODO: @nliber

@JohelEGP

This comment was marked as resolved.

@inbal2l
Copy link
Collaborator

inbal2l commented Nov 2, 2022

The outcome of the last poll doesn't seem to match the numbers.

Thank you for noticing. That was indeed an error and should be Consensus in favor. fixed.

@brycelelbach brycelelbach added needs-revision Paper needs changes before it can proceed and removed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Nov 2, 2022
@brevzin
Copy link
Collaborator

brevzin commented Dec 1, 2022

@brycelelbach FYI there's already an R1 of the paper, with the requested changes (no apply, handles private variant base).

@jensmaurer jensmaurer removed this from the 2022-telecon milestone Jan 25, 2023
@brycelelbach brycelelbach removed the needs-revision Paper needs changes before it can proceed label Mar 6, 2023
@brycelelbach brycelelbach added scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e labels Mar 25, 2023
@nliber
Copy link
Collaborator

nliber commented Apr 11, 2023

2022-04-11 Library Evolution Telecon

P2637R1: Member visit and apply

2023-04-11 Library Evolution Telecon Minutes

Champion: Barry Revzin

Chair: Nevin Liber

Minute Taker: Ben Craig

POLL: Deprecate std::visit_format_arg as part of P2637.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
1 8 5 1 1

Attendance: 23

# of Authors: 1

Author Position: N

Outcome: Weak consensus in favor

SA: No discussion, only impact

POLL: Modify P2637R1 (Member visit) by deprecating std::format_visit_arg, and then send the revised paper to LWG for C++26 classified as B2, to be confirmed with a Library Evolution electronic poll.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
6 9 1 2 0

Attendance: 23

# of Authors: 1

Author Position: SF

Outcome: Consensus in favor

Next Steps

Modify P2637R1 (Member visit) by deprecating std::format_visit_arg, and then send the revised paper to LWG for C++26 classified as B2, to be confirmed with a Library Evolution electronic poll.

@brycelelbach brycelelbach added needs-revision Paper needs changes before it can proceed ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels May 23, 2023
@brycelelbach
Copy link

P2637R2 will be in the 2023-05 mailing.

@brycelelbach brycelelbach added scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed needs-revision Paper needs changes before it can proceed labels May 24, 2023
@wg21bot wg21bot added this to the 2023-telecon milestone May 26, 2023
@wg21bot wg21bot changed the title P2637 Member visit and apply P2637 R2 Member visit May 26, 2023
@JeffGarland
Copy link
Member

LWG reviewed and approved for C++26 in Varna on Tue afternoon (notes to follow)

Poll: add [[http://wg21.link/p2637r3][p2637r3]] to C++26?

|F|A|N|
|9|0|1|

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. LWG Library labels Jun 13, 2023
@brycelelbach
Copy link

brycelelbach commented Jun 16, 2023

2023-05 Library Evolution Electronic Poll Outcomes

Poll 7: Send [[P2637R2]] Member visit to Library Working Group for C++26.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
13 6 0 2 1

Outcome: Consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 16, 2023
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Jun 17, 2023
@wg21bot
Copy link
Collaborator Author

wg21bot commented Jul 21, 2023

P2637R3 Member visit (Barry Revzin)

@wg21bot wg21bot changed the title P2637 R2 Member visit P2637 R3 Member visit Jul 21, 2023
@ben-craig ben-craig removed the LWG Library label Mar 5, 2024
@jwakely
Copy link
Member

jwakely commented Mar 5, 2024

Approved in Varna 2023 and applied to the draft (cplusplus/draft#6307)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++26 Targeted at C++26 IS Ship vehicle: IS plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - medium paper size estimate
Projects
None yet
Development

Successfully merging a pull request may close this issue.