Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some projects don't prepend the tag with 'v' for the version #167

Closed
mtvee opened this issue Nov 27, 2020 · 2 comments
Closed

Some projects don't prepend the tag with 'v' for the version #167

mtvee opened this issue Nov 27, 2020 · 2 comments

Comments

@mtvee
Copy link

mtvee commented Nov 27, 2020

Some projects don't use the 'v' when tagging. CPM.cmake assumes/adds a 'v' in front on the tag for VERSION. Perhaps it should just use what it is given?

<+>UTF-8
===================================================================
--- cmake/CPM.cmake	(revision 42a2615a11b234c89fbbfb687bfabcfff35848d7)
+++ cmake/CPM.cmake	(date 1606469749260)
@@ -226,7 +226,7 @@
     if (DEFINED CPM_ARGS_GIT_REPOSITORY)
         list(APPEND CPM_ARGS_UNPARSED_ARGUMENTS GIT_REPOSITORY ${CPM_ARGS_GIT_REPOSITORY})
         if (NOT DEFINED CPM_ARGS_GIT_TAG)
-            set(CPM_ARGS_GIT_TAG v${CPM_ARGS_VERSION})
+            set(CPM_ARGS_GIT_TAG ${CPM_ARGS_VERSION})
         endif()
     endif()
@TheLartians
Copy link
Member

TheLartians commented Nov 27, 2020

From my experience, most projects actually do use the v prefix. Also it's the suggested format by GitHub, so imo it's reasonable to have it as the default. For all other conventions you can still explicitly specify GIT_TAG besides the version.

@TheLartians
Copy link
Member

Also duplicate of #106 and #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants