Add needed Boost libs and OpenSSL headers to CMake config #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you verified that this works with versions of Boost as far back as 1.51? |
|
I've only tested against Boost 1.52. |
Provide source port number to requests
|
Okay, I'm willing to say that 0.9.5 is going to require Boost 1.52. I'm merging this now. LGTM |
deanberris
added a commit
that referenced
this pull request
Jan 24, 2013
Add needed Boost libs and OpenSSL headers to CMake config
|
FYI: I just did some testing against Boost 1.51 and I didn't see any difference in behavior from Boost 1.52. For both of them, all the tests pass (except |
|
Thanks Elliot -- can you share more about the get_timeout_test failures in a different issue? I would love to have a fix for this in 0.9.5. |
|
Sure: #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only tested this with Visual Studio 2010. Prior to this change, the Visual Studio projects generated by CMake would not build without manual configuration changes to link against the right Boost libraries and include OpenSSL's headers.