-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hdf5 package #12
Comments
Sounds good. The changes to hunterize are very minimal - are you interested in trying to get these merged upstream, or would you like a fork to be created in cpp-pm? |
I was initially thinking of forking it in cpp-pm but happy to do a pull request upstream (before / in parallel?) to see if they are interested in adopting hunter :) |
Don’t worry about it too much. We can make you a fork in cpp-pm |
https://github.com/cpp-pm/hdf5 Let us know if you are blocked on anything |
Thanks a lot, I'll apply the patch very soon and will let you know once it's done, I've built it on both linux & windows, do you guys have already set up a CI or anything similar to do a pre-release check? |
The current testing model is pretty ugly, but essentially every package has a branch here https://github.com/cpp-pm/hunter-testing/branches, with modifications to just the Travis and appveyor build paths, so that just the specific package is built on that branch. To run the builds, you essentially just push a commit with the Travis/appveyor changes on top of your PR ones |
Thanks! |
It’s up to you, but for stability reasons you probably want to stick to a formal release, unless you need the latest code for some reason. Also makes it easier for people to know which versions we have in hunter, versus a commit hash |
Made the pull request in cpp-pm/hdf5. |
The CI process is quite manual. The pkg.hd5 branch is really there just to track the state of testing for that package. To run the tests, you need to merge the pkg.hd5 and your hunter branch together, and push, and wait for the tests to run. It’s quite confusing - let me know if that makes sense |
Updated hdf5 & released in: https://github.com/cpp-pm/hdf5/archive/1.10.5-hp5.tar.gz |
hdf5
to hunter. It is a C++/Fortran/Java library to interact with hdf / h5 files. HDF5 is a standard hierarchical data file format commonly used to store raw sensor data as well as metadata.Only two dependencies were required ZLIB & szip, both on hunter (hence the hunterisation):
ZLIB
(available in Hunter: https://docs.hunter.sh/en/latest/packages/pkg/ZLIB.html)szip
(available in Hunter: https://docs.hunter.sh/en/latest/packages/pkg/szip.html)The text was updated successfully, but these errors were encountered: