Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package occt (OpenCascadeTechnology) #222

Open
craffael opened this issue Jul 9, 2020 · 7 comments
Open

New Package occt (OpenCascadeTechnology) #222

craffael opened this issue Jul 9, 2020 · 7 comments

Comments

@craffael
Copy link

craffael commented Jul 9, 2020

I'm planning to contribute OpenCascadeTechnology (occt) as a package to hunter. But for this to work I need to patch the source$s of occt. Can you create a repository cpp-pm/occt for me? (I'm basically following this guide)

@rbsheth
Copy link
Member

rbsheth commented Jul 13, 2020

@craffael That sounds good. Looks like they don't have an open git repository? I found this one http://git.dev.opencascade.org/gitweb/?p=occt.git

Do you have access to it already? We can make an empty git fork where you can push the code.

@craffael
Copy link
Author

You could fork it from here: https://github.com/Open-Cascade-SAS/OCCT

@rbsheth
Copy link
Member

rbsheth commented Jul 13, 2020

@craffael
Copy link
Author

Great, Thanks! It will probably take a while until it works because I'm going on holidays in a few days :)

@craffael
Copy link
Author

@rbsheth I've created a new branch hunter-7.4.0 in the cpp-pm/occt repository. But now I want push another change to this branch but I'm not allowed anymore because it somehow turned out to be a protected branch. Can you check my permissions for the occt repository? Or should I create a PR in that repo?

@craffael
Copy link
Author

Another problem that I currently have, is that OCCT is really a massive library and the time limit on travis is just too short in order to build debug + release versions of it. I see two options:

  1. disable all ci testing of the hunter package occt
  2. Somehow modify the ci setup so that debug and release builds are carried out separately. I guess I could modify jenkins.py so that I can pass an additional environment variable CONFIGURATION_TYPES which is the forwarded to polly.py...?

What do you think/prefer? Do you have another idea?

@rbsheth
Copy link
Member

rbsheth commented Aug 28, 2020

@rbsheth I've created a new branch hunter-7.4.0 in the cpp-pm/occt repository. But now I want push another change to this branch but I'm not allowed anymore because it somehow turned out to be a protected branch. Can you check my permissions for the occt repository? Or should I create a PR in that repo?

Yeah the hunter* branches are protected. You should make a PR/separate branch that doesn't start with hunter to make changes.

Another problem that I currently have, is that OCCT is really a massive library and the time limit on travis is just too short in order to build debug + release versions of it. I see two options:

  1. disable all ci testing of the hunter package occt
  2. Somehow modify the ci setup so that debug and release builds are carried out separately. I guess I could modify jenkins.py so that I can pass an additional environment variable CONFIGURATION_TYPES which is the forwarded to polly.py...?

What do you think/prefer? Do you have another idea?

Hmm, give the configuration types a try. You could also try Github Actions like #250 since Travis/AppVeyor will be deprecated in favor of Actions for our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants