Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "assimp" package #69

Closed
NukeBird opened this issue Nov 18, 2019 · 2 comments · Fixed by #232
Closed

Update "assimp" package #69

NukeBird opened this issue Nov 18, 2019 · 2 comments · Fixed by #232
Labels
help wanted Extra attention is needed

Comments

@NukeBird
Copy link
Member

NukeBird commented Nov 18, 2019

https://github.com/assimp/assimp/releases/tag/v5.0.0 (2d2889f)

I think it's very important update:

Implemented basic PBR materials into assimp.
This adds the following texture types:
BASE_COLOR
NORMAL_CAMERA
EMISSION_COLOR
METALNESS
DIFFUSE_ROUGHNESS

Add support for importing GLTF2 animations.

@NukeBird NukeBird added the help wanted Extra attention is needed label Nov 18, 2019
@NukeBird
Copy link
Member Author

actually I noticed just now that assimp uses hunter (but the ruslo ones, old version)
so update should be pretty straightforward

@NukeBird NukeBird changed the title Update "assimp" package to v5.0.0 Update "assimp" package Nov 18, 2019
@rbsheth
Copy link
Member

rbsheth commented Nov 18, 2019

@NukeBird Want to try your hand at updating the package? Like you said, it should be very straightforward since I added Hunter support directly there. If you do, make sure to test your updated branch with CI (https://docs.hunter.sh/en/latest/creating-new/update.html#testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants