Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knctl deploy --env parameter can't contain comma-separated value #58

Closed
jochenehret opened this issue Mar 13, 2019 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@jochenehret
Copy link

We are trying to deploy a Java application like this:

knctl deploy ... --env JAVA_OPTS=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005

It seems that the env value is truncated after the first comma:

ERROR: JDWP invalid option: -agentlib:jdwp=transport=dt_socket

We've tried different quoting variations (single quotes around value, double quotes etc.), but without success. Can you please check?

Thanks a lot for your support!

@matthew-petrie
Copy link

I believe we have a similar/same issue - the error message isn't helpful in our case
Error: Expected environment variable to be in format 'ENV_KEY=value'

Deployment:
knctl deploy ... --env MONGO_DB_URI="mongodb://<USERNAME>:<PASSWORD>@shard-00-00-qpzhp.gcp.mongodb.net:27017,shard-00-01-qpzhp.gcp.mongodb.net:27017,shard-00-02-qpzhp.gcp.mongodb.net:27017/test?ssl=true&replicaSet=shard-0&authSource=admin&retryWrites=true"

If we remove the env MONGO_DB_URI we don't get this error message

knctl is great; really appreciate all the work that's gone into it!

@cppforlife
Copy link
Owner

@jochenehret @Matthew1534 fix is in this commit: 1a23540. it's going through CI now; once it goes green i'll cut a new release.

thanks for reporting!

@cppforlife cppforlife added the enhancement New feature or request label Mar 21, 2019
@cppforlife
Copy link
Owner

fixed in https://github.com/cppforlife/knctl/releases/tag/v0.2.0

knctl is great; really appreciate all the work that's gone into it!

glad you find it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants