-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using SPDX license identifiers with custom logic operators seems odd #6
Comments
Using a single string with |
I'm not sure why a build system would want to do anything with the license information beyond I have a bunch of concerns about inventing another format, when there is a well speced format that is growing in acceptance, and is widely supported outside of CPS. Using nested lists to denote semantic meaning is not immediately obvious when reading. A well meaning person is absolutely going to see SPDX is also in common use, it's an ISO standard. Looking around briefly, it appears that Rust's Cargo, Python's PIP, and NPM, all require their licensing information to be in SPDX format. Ruby's GEM format and build2's package format strongly guide one to use SPDX. Meson strongly recommends it (we used to have a very similar bracketed format but deprecated it in part because people were confused by it), and in 2.0 we will require SPDX. As a build system implementer I'm simply going to collect the license information and pass that along to another tool like blackduck. In fact, with my Intel hat on, doing SBOM work is part of my job. Our tools natively understand SPDX (or maybe with a plug-in, but it's not something I have to think about), but they don't understand CPS's nested list, so now I actually do have to implement a tool that can convert from this one off format to SPDX so my tooling can consume it, which means I both need to understand the semantics of CPS and I need to understand the semantics of SPDX. |
Per prior comment, I am hesitant to change the specification in a way that increases implementation burden without a better understanding of how this particular tag is likely to be used in practice. Accordingly, I am tagging this as needing further discussion/investigation. |
Why not just use the full SPDX logic of AND, OR, and WITH? There's already parsers that understand that, and especially for users who need to evaluate licenses with external tools (I'm thinking things like blackduck) which already understand SPDX it probably makes more sense to write
"Apache-2.0 OR GPL-2.0-only"
than["Apache-2.0", "GPL-2.0-only"]
, which doesn't require someone to transform the CPS specific form into the standardized SPDX form (which has been submitted as an ISO standard).The text was updated successfully, but these errors were encountered: