Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol substitution converts symbols that are a multiple of 4 to zero #219

Closed
cqc-alec opened this issue Feb 15, 2022 · 0 comments · Fixed by #220
Closed

Symbol substitution converts symbols that are a multiple of 4 to zero #219

cqc-alec opened this issue Feb 15, 2022 · 0 comments · Fixed by #220
Labels
bug Something isn't working

Comments

@cqc-alec
Copy link
Collaborator

This was a hasty workaround for a symengine issue:

tket/tket/src/Circuit/Circuit.cpp

Line 142 in 87a4eff

// This is a workaround for a symengine issue: symengine currently has poor
.
However it leads to incorrect results if the symbol is part of a larger expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't assume expressions being substituted are mod 4 CQCL/tket
1 participant
@cqc-alec