Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax typing restriction on KwargTypes = Union[int, float, str, None] #868

Closed
cqc-alec opened this issue May 18, 2023 · 1 comment · Fixed by #1500
Closed

Relax typing restriction on KwargTypes = Union[int, float, str, None] #868

cqc-alec opened this issue May 18, 2023 · 1 comment · Fixed by #1500
Assignees
@cqc-alec

Comments

@cqc-alec
Copy link
Collaborator

We use this in several places in pytket but there seems no real reason to restrict to these types. For example it doesn't allow type checking when we want to pass enums as kwargs.
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale.

@github-actions github-actions bot added the stale label Jun 12, 2024
@cqc-alec cqc-alec self-assigned this Jul 23, 2024
@cqc-alec cqc-alec mentioned this issue Jul 23, 2024
Merged
@github-actions github-actions bot removed the stale label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqc-alec cqc-alec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow any kwarg type. CQCL/tket
1 participant
@cqc-alec