Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use array.eo directly from eo-runtime #515

Merged
merged 2 commits into from Dec 22, 2021

Conversation

baudoliver7
Copy link
Member

In eo-maven-plugin tests, we now use directly original file array.eo (belonging to eo-runtime). No need to use symlink.
Both windows and linux support this.

Ref: #465

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #515 (bd1014e) into master (516bce2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #515   +/-   ##
=========================================
  Coverage     87.53%   87.53%           
  Complexity       92       92           
=========================================
  Files             8        8           
  Lines           337      337           
  Branches         37       37           
=========================================
  Hits            295      295           
  Misses           34       34           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516bce2...bd1014e. Read the comment docs.

@baudoliver7
Copy link
Member Author

@yegor256 The project works fine on Windows now :-)

@yegor256
Copy link
Member

@rultor merge

@yegor256
Copy link
Member

@baudoliver7 thanks a lot!

@rultor
Copy link
Contributor

rultor commented Dec 22, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit bd1014e into objectionary:master Dec 22, 2021
@baudoliver7 baudoliver7 deleted the 456_use_array_eo_file branch December 22, 2021 04:30
@rultor
Copy link
Contributor

rultor commented Dec 22, 2021

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@0crat
Copy link

0crat commented Dec 22, 2021

Job gh:cqfn/eo#515 is not assigned, can't get performer

@0crat
Copy link

0crat commented Jan 16, 2022

@yegor256/z everybody who has role REV is banned at #515; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants