-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced sin and cos in runtime #598
Introduced sin and cos in runtime #598
Conversation
@maxonfjvipon I think it would be better to have |
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
============================================
+ Coverage 80.82% 80.88% +0.06%
Complexity 477 477
============================================
Files 133 135 +2
Lines 2487 2495 +8
Branches 222 222
============================================
+ Hits 2010 2018 +8
Misses 404 404
Partials 73 73
Continue to review full report at Codecov.
|
@yegor256 please check this out. If it's good I would continue to add more objects like these. |
@maxonfjvipon all looks good now, but you also should add these two "methods" to |
@maxonfjvipon also, would be nice if you would add some tests to |
@yegor256 Ok. Will be done soon |
@maxonfjvipon if you think that the PR is ready for merging, say so explicitly by posting a new message. Otherwise, it will hang in there forever :) |
@yegor256 Oh, my bad) I think the PR is ready to merge |
@rultor merge |
@maxonfjvipon thanks! |
Job |
No description provided.