Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced sin and cos in runtime #598

Merged
merged 8 commits into from
Mar 25, 2022
Merged

Introduced sin and cos in runtime #598

merged 8 commits into from
Mar 25, 2022

Conversation

maxonfjvipon
Copy link
Member

No description provided.

@maxonfjvipon maxonfjvipon changed the title #597 Introduced sin and cos in runtime Introduced sin and cos in runtime Mar 11, 2022
@yegor256
Copy link
Member

@maxonfjvipon I think it would be better to have float.cos and float.sin instead of cos and sin standalone objects.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #598 (c4c74a2) into master (5406f43) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #598      +/-   ##
============================================
+ Coverage     80.82%   80.88%   +0.06%     
  Complexity      477      477              
============================================
  Files           133      135       +2     
  Lines          2487     2495       +8     
  Branches        222      222              
============================================
+ Hits           2010     2018       +8     
  Misses          404      404              
  Partials         73       73              
Impacted Files Coverage Δ
...me/src/main/java/EOorg/EOeolang/EOfloat$EOcos.java 100.00% <100.00%> (ø)
...me/src/main/java/EOorg/EOeolang/EOfloat$EOsin.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5406f43...c4c74a2. Read the comment docs.

@maxonfjvipon
Copy link
Member Author

@yegor256 please check this out. If it's good I would continue to add more objects like these.
Also I wanted to ask about these objects written in eo: should I make a PR at this repository or at objectionary?

@yegor256
Copy link
Member

@maxonfjvipon all looks good now, but you also should add these two "methods" to float.eo file. Otherwise, they won't be visible by EO compiler. No need to touch "objectionary": your objects will appear there automatically, once we release a new version of this repository to Maven Central.

@yegor256
Copy link
Member

@maxonfjvipon also, would be nice if you would add some tests to float-tests.eo.

@maxonfjvipon
Copy link
Member Author

@yegor256 Ok. Will be done soon

Added tests for sin and cos to float-tests.eo
#597 #598
@yegor256
Copy link
Member

@maxonfjvipon if you think that the PR is ready for merging, say so explicitly by posting a new message. Otherwise, it will hang in there forever :)

@maxonfjvipon
Copy link
Member Author

@yegor256 Oh, my bad) I think the PR is ready to merge

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 25, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 029ae47 into objectionary:master Mar 25, 2022
@rultor
Copy link
Contributor

rultor commented Mar 25, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)

@maxonfjvipon maxonfjvipon deleted the maxonfjvipon-trigonometry branch March 25, 2022 11:20
@yegor256
Copy link
Member

@maxonfjvipon thanks!

@0crat
Copy link

0crat commented Mar 25, 2022

Job gh:cqfn/eo#598 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants