Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlMethodCall.java:35-37: This class XmlMethodCall should... #443

Closed
0pdd opened this issue Apr 9, 2020 · 12 comments
Closed

XmlMethodCall.java:35-37: This class XmlMethodCall should... #443

0pdd opened this issue Apr 9, 2020 · 12 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 9, 2020

The puzzle 440-332bf733 from #440 has to be resolved:

https://github.com/yegor256/jpeek/blob/94b2e98a33d57f864f7ac8a82ae373de11cc5f20/src/main/java/org/jpeek/graph/XmlMethodCall.java#L35-L37

The puzzle was created by Victor Noël on 09-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Apr 9, 2020

@paulodamaso/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Apr 9, 2020

The job #443 assigned to @vzurauskas/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@vzurauskas
Copy link
Contributor

@paulodamaso XmlMethodCall expects an XML in its constructor. Can you clarify whether this XML is supposed to be method, or op from within the method? Judging from the name of the class ("call" is a type of "op") and the way this class is used in XmlGraph, it should expect an op, but the way it's implemented, it expects a method: it expects the XML to contain name and args, and as far as I can tell, op elements don't have them.

@vzurauskas
Copy link
Contributor

@0crat wait for an answer

@vzurauskas
Copy link
Contributor

@paulodamaso ping

@paulodamaso
Copy link
Collaborator

@vzurauskas Seems that it is supposed to be a method

@vzurauskas
Copy link
Contributor

@paulodamaso I stumbled upon this comment today. It turns out there are plans to enhance the op element with everything required for XmlMethodCall as it is now. So turns out it's an op after all.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 21, 2020

The puzzle 440-332bf733 has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link
Collaborator

0crat commented Apr 21, 2020

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 21, 2020
@sereshqua
Copy link

@0crat quality good

@sereshqua
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2020

@0crat quality good (here)

@sereshqua There is no quality review for #443, no performer

@0crat 0crat added quality/good and removed qa labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants