-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate metrics.xml in pure Java, without XSLT #296
Comments
@paulodamaso/z please, pay attention to this issue |
The class Report doesn't follow a contract. It's a concrete class that ties the report generation to the XSL implementation. Refactoring with extract interface should allow custom metrics to be implemented in Java rather than in XSL. |
@danilomo Yes, I think Report should become an interface and the current concrete class Report renamed to XslReport or something |
Some graph algorithms are extremely annoying to implement with XSL. They are doable, though, since you can have recursive templates, but nevertheless, it would be way easier to write them in Java. So, I would like to know what do you think about this issue. Thanks in advance. |
@ilyakharlamov How about making some performance tests to measure xml speed / efficiency and then implement some routines in java to compare both? |
@paulodamaso This issue is not about the performance. |
@ilyakharlamov Understood the problem. XSL was chosen because its performance, but as it does not have the required features it's time to move on to some more robust implementation. |
@0crat in |
@paulodamaso Job #296 is now in scope, role is |
Bug was reported, see §29: +15 point(s) just awarded to @ilyakharlamov/z |
Resigned on delay, see §8: -30 point(s) just awarded to @ebercamargo/z |
The user @ebercamargo/z resigned from #296, please stop working. Reason for job resignation: It is older than 10 days, see §8 |
@paulodamaso @danilomo I agree that we should think about Java implementations of |
The user @monomonedula/z resigned from #296, please stop working. Reason for job resignation: It is older than 10 days, see §8 |
Resigned on delay, see §8: -30 point(s) just awarded to @monomonedula/z |
@paulodamaso/z not enough funds available in the project, can't set budget of job #296, see §21; @RajanAMistry/z will get no money on completion; in order to fix that, add funds to the project and assign the job again |
@RajanAMistry/z this job was assigned to you 8days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
The user @RajanAMistry/z resigned from #296, please stop working. Reason for job resignation: It is older than 10 days, see §8 |
Resigned on delay, see §8: -30 point(s) just awarded to @RajanAMistry/z |
@ilyakharlamov I resolved the main part
The option is now here. That's what can be done in 30min. I don't know if you/we should create separate issues for specific metrics to be implemented in Java, or if you have in mind any specific metric that absolutely must be implemented, I could add a puzzle. |
@paulodamaso any opinion here? |
@HDouss We need to have hooks / checkpoints which allows us to continue to break a complex task in many other micro-tasks. These hooks came in forma of puzzles in the code, and using them we will be able to know how much we still have to do and what is left to implement for our feature to be complete. I should have asked you to put these puzzles in the code before the merge. We need these puzzles, so could you please add them? |
@paulodamaso that's what I said in:
However the puzzle should be precise. Should we implement all the metrics in Java? Are they some must-have implementations in Java. I can't just say "implement some metrics" in Java. |
@paulodamaso puzzle added in PR #389 |
@ilyakharlamov the puzzle #390 is still not solved. |
@ilyakharlamov PR #389 added a puzzle and merged. Please close the issue. |
@ilyakharlamov ping |
@ilyakharlamov PR #389 merged. Please close the issue. |
@sereshqua/z please review this job completed by @HDouss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality good |
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
@ilyakharlamov 2 puzzles #396, #397 are still not solved; solved: #390. |
@ilyakharlamov the puzzle #397 is still not solved; solved: #390, #396. |
@ilyakharlamov the puzzle #408 is still not solved; solved: #390, #396, #397. |
The current architecture relies heavily on XSLT for data analysis.
If we want to implement issues like #204 with advanced semantic indexing such as ML, LSI, NLP
we'll have to use external Java libraries since it's very challenging to do complex calculations in pure XSLT.
So we need to have an option to generate an XML report by name, that is implemented in Java, not XSLT.
The text was updated successfully, but these errors were encountered: