-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure service subject reporttype bugs #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Capt-Mac
commented
Oct 3, 2023
- Update r4MeasureService from hapi-fhir MeasureService
- Fix bug where reportType=null does not cause error
- Add capability for r4 evaluateMeasure to handle practitioner & practitioner group via R4SubjectProvider
- Fix bug where summary subject references were not being populated by Group/Practitioner references
- update Measure Given tests to use MeasureService instead of processor
…ractitionerGroup paramter, reporter param
Formatting check succeeded! |
barhodes
approved these changes
Oct 4, 2023
cqf-fhir-cr/src/main/java/org/opencds/cqf/fhir/cr/measure/r4/R4MeasureProcessor.java
Outdated
Show resolved
Hide resolved
barhodes
added a commit
that referenced
this pull request
Oct 30, 2023
commit af2db9a Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Fri Oct 27 10:25:08 2023 -0600 snapshot 3.0.0-PRE-10 (#371) commit 0ff4f32 Author: JP <jonathan.percival@smilecdr.com> Date: Thu Oct 26 13:15:54 2023 -0600 Update versions and fix build / test publication (#370) commit b235356 Author: JP <jonathan.percival@smilecdr.com> Date: Fri Oct 20 10:42:06 2023 -0600 Feature use new java extension (#364) * Swap to Java Platform Support extension for VS Code * Fix up pom * pom clean-up * Fix warnings * Fix formatting * Update java version and distribution * Add maven cache * Add implicit flag for benchmarks commit 9790135 Author: Vitor Pamplona <vitor@vitorpamplona.com> Date: Mon Oct 16 15:35:08 2023 -0400 Fixes crash on measure evaluate when subjectIds is null (#359) Fixes #358 commit 5b5414e Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com> Date: Thu Oct 12 09:53:00 2023 -0600 isolate getsubjects method in Measure Processor (#361) spotless apply commit 0fe8e3a Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 14:36:08 2023 -0600 Rev to PRE9 Snapshot commit 4b799ca Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 13:28:25 2023 -0600 --amend commit d3f7b09 Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 13:16:37 2023 -0600 Rev to release version commit 8057c70 Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com> Date: Wed Oct 4 10:32:11 2023 -0600 Measure service subject reporttype bugs (#354) * fix reportType null bug, add subject & practitioner referenc to MR, practitionerGroup paramter, reporter param * add measureService tests for r4 * spotless apply fixes * copy reportType setting from r4 to Dstu3 processor * revert defaulting logic for reportType, add check for null item in list for default reportType * remove commented out code, spotless apply edits --------- Co-authored-by: JP <jonathan.percival@smilecdr.com> commit ad744bd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 4 10:27:14 2023 -0600 Bump pillow from 9.4.0 to 10.0.1 in /docs/src/doc (#355) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.4.0...10.0.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 87434a4 Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Mon Oct 2 22:15:46 2023 -0600 More performance tweaks commit 85e8933 Author: Jason Evans <jason.a.evans@gmail.com> Date: Mon Oct 2 21:50:01 2023 -0600 KA issue 32 - optimize CQL for Lantana (#352) * Update GlycemicControlHypoglycemicInitialPopulation.cql * SupplementalDataElements changes * MATGlobalCommonFunctions R4 changes * MATGlobalCommonFunctions R3 changes * MATGlobalCommonFunctions QICore R4 changes * Fixes / optimizations * Revert non-CaseRepresentation content * Restore additional content --------- Co-authored-by: JP <jonathan.percival@smilecdr.com> Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com> commit 4e7500e Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Mon Oct 2 20:40:14 2023 -0600 repository search by id (#353) * repository search by id * apply formatting * separate InMemory test * remove redundancy * search by id update * search by id update test * search by id update test script * reformat * Fix repository and tests * Fixes for repo api --------- Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com> Co-authored-by: JP <jonathan.percival@smilecdr.com> commit a9af518 Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Mon Oct 2 10:42:24 2023 -0600 add measure extension url publish pages (#349) * add measure extension url publish pages * apply formatting
JPercival
added a commit
that referenced
this pull request
Nov 19, 2023
* Experiment * Codecov action * Add jacoco to package profile * Add ignored paths * Fix test report uploads * Squashed commit of the following: commit af2db9a Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Fri Oct 27 10:25:08 2023 -0600 snapshot 3.0.0-PRE-10 (#371) commit 0ff4f32 Author: JP <jonathan.percival@smilecdr.com> Date: Thu Oct 26 13:15:54 2023 -0600 Update versions and fix build / test publication (#370) commit b235356 Author: JP <jonathan.percival@smilecdr.com> Date: Fri Oct 20 10:42:06 2023 -0600 Feature use new java extension (#364) * Swap to Java Platform Support extension for VS Code * Fix up pom * pom clean-up * Fix warnings * Fix formatting * Update java version and distribution * Add maven cache * Add implicit flag for benchmarks commit 9790135 Author: Vitor Pamplona <vitor@vitorpamplona.com> Date: Mon Oct 16 15:35:08 2023 -0400 Fixes crash on measure evaluate when subjectIds is null (#359) Fixes #358 commit 5b5414e Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com> Date: Thu Oct 12 09:53:00 2023 -0600 isolate getsubjects method in Measure Processor (#361) spotless apply commit 0fe8e3a Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 14:36:08 2023 -0600 Rev to PRE9 Snapshot commit 4b799ca Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 13:28:25 2023 -0600 --amend commit d3f7b09 Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Thu Oct 5 13:16:37 2023 -0600 Rev to release version commit 8057c70 Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com> Date: Wed Oct 4 10:32:11 2023 -0600 Measure service subject reporttype bugs (#354) * fix reportType null bug, add subject & practitioner referenc to MR, practitionerGroup paramter, reporter param * add measureService tests for r4 * spotless apply fixes * copy reportType setting from r4 to Dstu3 processor * revert defaulting logic for reportType, add check for null item in list for default reportType * remove commented out code, spotless apply edits --------- Co-authored-by: JP <jonathan.percival@smilecdr.com> commit ad744bd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 4 10:27:14 2023 -0600 Bump pillow from 9.4.0 to 10.0.1 in /docs/src/doc (#355) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.4.0...10.0.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 87434a4 Author: Jonathan Percival <jonathan.i.percival@gmail.com> Date: Mon Oct 2 22:15:46 2023 -0600 More performance tweaks commit 85e8933 Author: Jason Evans <jason.a.evans@gmail.com> Date: Mon Oct 2 21:50:01 2023 -0600 KA issue 32 - optimize CQL for Lantana (#352) * Update GlycemicControlHypoglycemicInitialPopulation.cql * SupplementalDataElements changes * MATGlobalCommonFunctions R4 changes * MATGlobalCommonFunctions R3 changes * MATGlobalCommonFunctions QICore R4 changes * Fixes / optimizations * Revert non-CaseRepresentation content * Restore additional content --------- Co-authored-by: JP <jonathan.percival@smilecdr.com> Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com> commit 4e7500e Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Mon Oct 2 20:40:14 2023 -0600 repository search by id (#353) * repository search by id * apply formatting * separate InMemory test * remove redundancy * search by id update * search by id update test * search by id update test script * reformat * Fix repository and tests * Fixes for repo api --------- Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com> Co-authored-by: JP <jonathan.percival@smilecdr.com> commit a9af518 Author: mdnazmulkarim <nazmul.karim@smilecdr.com> Date: Mon Oct 2 10:42:24 2023 -0600 add measure extension url publish pages (#349) * add measure extension url publish pages * apply formatting * Revert "Squashed commit of the following:" This reverts commit 5ef7c00. * Fix paths --------- Co-authored-by: Brenin Rhodes <brenin@alphora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.