-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible refactoring of the code base #38
Comments
oh, I thought about the pressure feature as well. Nice Demo! As improvement maybe disable the feature on pc or devices without the pressure function, because they are not able to draw a long thin line anymore :) Thanks for your offer. |
I do like simplicity. Still, I personally prefer when things are a bit more modularized / in several files. Which requires some kind of a build chain with Javascript. I see the following other advantages of having a JS build chain:
Also with Javascript we should be able to have hot reloading so it wouldn't be necessary to reload the webpage or rebuild in dev. If you are ok, I can take a bit of time to set up such a build chain for this project ; we shall see if we move forward with a bit of refactoring later. |
ok, lets give it a try. Please keep it simple :) |
Well, it took me a bit more time than I thought, but the result is here: #39 Even if I don't know how I could make it more complicated, I think it is fairly simple :) |
Thanks again 👍 |
Hi @cracker0dks
First of all, very nice project :)
Due to the confinement I have a bit of extra free time. @jb-leger is interested in adding a pressure sensitive feature and suggested I take a look at it. I did a little POC here https://github.com/FloChehab/whiteboard/tree/feat/pressure_drawing .
By doing so, I was thinking about updating the code base to ES6+ and adding some tooling (webpack, babel, etc.) to change the way libs are handled, simplify the code base and make it easier to dive in / extend.
As this would require a big refactoring / rewrite, adding dependencies, etc. I wonder if you'd be interested in such a thing: I won't do it, if you don't want it.
The text was updated successfully, but these errors were encountered: