Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up resample_melody_series #218

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Conversation

rabitt
Copy link
Contributor

@rabitt rabitt commented Aug 26, 2016

Originally resample_melody_series would resample no matter what, and this caused things to be slow when calling melody metrics many times on small segments (my use case).

Now, resample_melody_series first checks if the timebase is the same, and if it is simply returns back the original arrays rather than going through the resampling.

@craffel
Copy link
Collaborator

craffel commented Aug 27, 2016

Nice, thank you! You are in luck, because doing the docstring audit for 0.4 is taking me forever, so we can still squeeze this into 0.4. Can you

  1. Add a note to the docstring which says that times and times_new are equivalent, no resampling will be performed
  2. Add a note to the changelog?

Thanks!

@craffel craffel added this to the 0.4 milestone Aug 27, 2016
@rabitt
Copy link
Contributor Author

rabitt commented Aug 27, 2016

Done!

@craffel
Copy link
Collaborator

craffel commented Aug 27, 2016

LGTM, merging!

@craffel craffel merged commit 0d9cdc7 into mir-evaluation:master Aug 27, 2016
craffel added a commit that referenced this pull request Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants