Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date expired discounts still applied if code already in cart #711

Closed
nfourtythree opened this issue Feb 13, 2019 · 0 comments
Closed

Date expired discounts still applied if code already in cart #711

nfourtythree opened this issue Feb 13, 2019 · 0 comments

Comments

@nfourtythree
Copy link
Contributor

Description

If a user enters a discount code into the cart before and end date and then returns when the cart is still active but the discount end date has passed.

There is an error message that is displayed stating an out of date code but the adjustments are still being made to the cart.

Steps to reproduce

  1. Create discount code with an end date in the future
  2. Create order using the discount code when valid
  3. Change discount code end date with a date in the past

Additional info

  • Craft version: Craft Pro 3.0.33
  • PHP version: 2.0.0-beta.13.1
  • Database driver & version: MySQL 5.7.22

I know that versions are a bit out-of-date, this is the plan to be rectified in the near future. So apologies if this has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant