Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expired subscription reports status as 'Trialing' if trial was in place #723

Closed
shornuk opened this issue Feb 18, 2019 · 2 comments
Closed

Expired subscription reports status as 'Trialing' if trial was in place #723

shornuk opened this issue Feb 18, 2019 · 2 comments
Assignees
@lukeholder
Labels
bug
Milestone
2.2

Comments

@shornuk
Copy link

shornuk commented Feb 18, 2019 •
edited
Loading

Description

Setting up a new subscription with a free trial in place. After the free trial period, payment attempted and failed. After Stripes retries, the subscription is marked as expired. The subscription is Craft has isExpired set to 1 but subscription.status returns Trialing rather than Expired.

Additional info

  • Craft version: 3.1.10
  • PHP version: 7.1.25
  • Commerce: 2.0.4
@lukeholder
Copy link
Member

Sounds like a bug, will look into it.

@lukeholder lukeholder added the bug label Mar 5, 2019
@lukeholder lukeholder self-assigned this Aug 22, 2019
@lukeholder lukeholder added this to the 2.2 milestone Oct 10, 2019
@lukeholder
Copy link
Member

Commerce no longer has a Trialing status, and Subscription::isOnTrial() will now return false if it is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeholder lukeholder

Labels
bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
3 participants
@lukeholder @andris-sevcenko @shornuk