Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Shopify 404 prefetching hangs #22

Closed
wiebekaai opened this issue Mar 21, 2024 · 2 comments
Closed

Local Shopify 404 prefetching hangs #22

wiebekaai opened this issue Mar 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@wiebekaai
Copy link

Describe the bug
Working with Shopify locally, prefetching 404s throws a JavaScript error without displaying the 404 page to the user. On production it works as expected and skips the transition, bringing you to the 404 page.

From my screenshots, the issue seems to be related to the way Shopify handles tracking (Web Pixel Manager). I'd be happy to show you an example setup in a screen share.

To Reproduce
Steps to reproduce the behavior:

  • Configure transition with removeOldContent: false and bypassCache: true (remove old content in onEnterCompleted()).
  • Use the Shopify CLI to start a project.
  • Browse to the locally hosted Shopify theme (http://127.0.0.1:9292)
  • Hover a 404 link.
  • Click the link.
  • The onLeave transition is triggered, but it does not navigate to the 404 page.

image
image

Info

  • Device: Macbook
  • OS: macOS Sonoma
  • Browser: Chrome
  • Version: 122

Follow up of #21

@wiebekaai wiebekaai added the bug Something isn't working label Mar 21, 2024
@jakewhiteley
Copy link
Member

Could I ask which taxi version this is? I assume the most recent

@wiebekaai
Copy link
Author

Could I ask which taxi version this is? I assume the most recent

Yes. Tried to reproduce and doesn't seem to happen anymore. Maybe I tried with a cached version before. Thanks again :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants