Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch: prevent un authenticated cluster from returning a 401 #494

Merged
merged 1 commit into from
May 16, 2024

Conversation

khalifan-kfan
Copy link
Contributor

Description

This PR is to prevent the backend from returning a 401 error when the cluster connection is not authenticated

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Trello Ticket ID

https://trello.com/c/lPXN0HFS

How Can This Be Tested?

  1. Run this branch
  2. update your cluster token to the wrong one locally (add a new one if you don't have a token, use the right token when adding and then update to a wrong token.
  3. Try out any of the endpoints edited in the code changes, a simple one would be creating a project, The cluster should return a 401 but the endpoint should return 511 in this place

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@khalifan-kfan khalifan-kfan merged commit ad0fe85 into develop May 16, 2024
6 checks passed
@khalifan-kfan khalifan-kfan deleted the fx-cluster-401 branch May 16, 2024 12:27
khalifan-kfan added a commit that referenced this pull request May 16, 2024
* Adding email to user token (#491)

* Adding email to user token

* Adding email

* chore: add cluster information to the project (#492)

* Fx project details (#493)

* chore: add cluster information to the project

* Hot-fix: Non admin user project fetch

* ch: prevent un authenticated cluster from returning a 401 (#494)

---------

Co-authored-by: LanternNassi <71936382+LanternNassi@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants