Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add cluster information to the project #492

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore: add cluster information to the project #492

merged 1 commit into from
Apr 12, 2024

Conversation

khalifan-kfan
Copy link
Contributor

Description

This PR adds fields to the project details endpoint relevant for the new micro service arch set up

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Trello Ticket ID

https://trello.com/c/YW8MMdIi

How Can This Be Tested?

Run this branch and try to recover a single project's details

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

rhodinemma
rhodinemma approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@rhodinemma rhodinemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍🏾

@khalifan-kfan khalifan-kfan merged commit 62a6544 into develop Apr 12, 2024
6 checks passed
@khalifan-kfan khalifan-kfan deleted the ch-project-infor branch April 12, 2024 04:15
khalifan-kfan added a commit that referenced this pull request May 16, 2024
@khalifan-kfan @LanternNassi
Update Micro-service product application (#497)
fc8b123 
* Adding email to user token (#491)

* Adding email to user token

* Adding email

* chore: add cluster information to the project (#492)

* Fx project details (#493)

* chore: add cluster information to the project

* Hot-fix: Non admin user project fetch

* ch: prevent un authenticated cluster from returning a 401 (#494)

---------

Co-authored-by: LanternNassi <71936382+LanternNassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhodinemma rhodinemma rhodinemma approved these changes

@Mubangizi Mubangizi Awaiting requested review from Mubangizi

@LanternNassi LanternNassi Awaiting requested review from LanternNassi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalifan-kfan @rhodinemma