Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does Docker belong among the CIs? #16

Open
epage opened this issue Jan 8, 2019 · 1 comment
Open

Does Docker belong among the CIs? #16

epage opened this issue Jan 8, 2019 · 1 comment
Labels
breaking-change question Further information is requested

Comments

@epage
Copy link
Contributor

epage commented Jan 8, 2019

While I think we should maintain support for looking up docker information, having it in the CI struct is what I'm calling into question

  • If a CI uses docker and we later add native support for that CI, then behavior will change and possibly break the user because their CI will probably be in a catch-all pattern in a match.
@epage epage added question Further information is requested breaking-change labels Jan 8, 2019
@epage
Copy link
Contributor Author

epage commented Jan 8, 2019

I had other concerns but they escape me atm; will update when I remember them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage